[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

[Stefano Babic]

On 08/25/2011 08:29 AM, Faisal H wrote:
> While building with omap3_beagle_config configuration,
> getting an error about not finding asm/arch/gpio.h (which does not exist).
> Found that header files are moved to arch/arm/include/asm/arch-.

"make <board>_config" sets a link for asm/arch to
arch/arm/include/asm/arch-. The file is not moved.

Then in my understanding asm/arch/gpio.h is included in asm/gpio.h, and
must not be included directly. Have I missed something ?


> Fixed the includes to find the file..
> 
> Signed-off-by: Faisal Hassan<faah87 at gmail.com>
> Cc: Wolfgang Denk<wd at denx.de>
> 
> 
> --- a/board/cm-bf537e/gpio_cfi_flash.c
> +++ b/board/cm-bf537e/gpio_cfi_flash.c
> @@ -8,7 +8,7 @@
> 
>   #include<common.h>
>   #include<asm/blackfin.h>
> -#include<asm/gpio.h>
> +#include<asm/mach-bf537/gpio.h>

However, asm/gpio.h is the correct general interface. The specific part
for the microprocessor is included with #include <asm/arch/gpio.h> in
asm/gpio.h.

You should not need to change it if the links are correctly set. If not,
it is another bug.

>   #include<asm/blackfin.h>
> -#include<asm/gpio.h>
> +#include<asm/mach-bf548/gpio.h>

IMHO this change is wrong, and it is correct how it is done currently.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================