[U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

York Sun yorksun at freescale.com
Thu Aug 25 22:57:01 CEST 2011


Wolfgang,

On Thu, 2011-08-25 at 00:36 +0200, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1312923045-2612-5-git-send-email-yorksun at freescale.com> you wrote:
> > Unified DDR driver is maintained for better performance, robustness and bug
> > fixes. Upgrading to use unified DDR driver for MPC83xx takes advantage of
> > overall improvement. It requires changes for board files to customize
> > platform-dependent parameters.
> > 
> > To utilize the unified DDR driver, a board needs to define CONFIG_FSL_DDRx
> > in the header file. No more boards will be accepted without such definition.
> > 
> > Note: the workaround for erratum DDR6 for the very old MPC834x Rev 1.0/1.1
> > and MPC8360 Rev 1.1/1.2 parts is not migrated to unified driver.
> > 
> > Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> > Signed-off-by: York Sun <yorksun at freescale.com>
> 
> Checkpatch says:
> 
> WARNING: do not add new typedefs
> #408: FILE: arch/powerpc/include/asm/immap_83xx.h:289:
> +typedef struct ccsr_ddr {
> 
> Please fix.
> 

I can fix the new tyepdef. But this one isn't. It has been used for a
long time by 85xx. I am trying to unified the code. It is inevitable to
define the same typedef for 83xx.

Regards,

York
 




More information about the U-Boot mailing list