[U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S

Simon Glass sjg at chromium.org
Fri Dec 9 04:42:24 CET 2011


Hi Mike,

On Mon, Nov 28, 2011 at 7:15 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 21 November 2011 18:58:00 Simon Glass wrote:
>> --- a/board/reloc.c
>> +++ b/board/reloc.c
>>
>> -void new_relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
>> +void relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
>
> this is too fragile.  we can't have every arch transition the way you did with
> arm (otherwise arches that have transitioned will break in between).  declare
> this func weak and don't rename it.  then there should be no migration issue.
> -mike

Yes I will do that, thanks. We can always remove it later when archs
have all moved over.

Regards,
Simon


More information about the U-Boot mailing list