[U-Boot] [PATCH] M28: Cleanup memsize.o OOT build

[Stefano Babic]

On 08/12/2011 13:27, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Detlev Zundel <dzu at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> ---

Hi Marek,

>  arch/arm/cpu/arm926ejs/mx28/Makefile       |    7 +------
>  arch/arm/cpu/arm926ejs/mx28/spl_boot.c     |   13 ++-----------
>  arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds |   12 ++++++------
>  include/configs/m28evk.h                   |    2 ++
>  4 files changed, 11 insertions(+), 23 deletions(-)
> 

It seems to me that your patch does much more as what you describe in
the commit message.

> diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_boot.c b/arch/arm/cpu/arm926ejs/mx28/spl_boot.c
> index 3cd4c24..dfb8309 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/spl_boot.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/spl_boot.c
> @@ -68,17 +68,8 @@ inline void board_init_r(gd_t *id, ulong dest_addr)
>  		;
>  }
>  
> -inline int printf(const char *fmt, ...)
> -{
> -	return 0;
> -}
> -
> -inline void __coloured_LED_init(void) {}
> -inline void __red_LED_on(void) {}
> -void coloured_LED_init(void)
> -	__attribute__((weak, alias("__coloured_LED_init")));
> -void red_LED_on(void)
> -	__attribute__((weak, alias("__red_LED_on")));
> +void serial_putc(const char c) {}
> +void serial_puts(const char *s) {}

Make a note in the commit message about these changes (not related to
the subject)

>  void hang(void) __attribute__ ((noreturn));
>  void hang(void)
>  {
> diff --git a/arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds b/arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds
> index 893320f..0fccd52 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds
> +++ b/arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds
> @@ -67,16 +67,16 @@ SECTIONS
>  		*(.dynsym)
>  	}
>  
> -	_end = .;
> -
> -	.bss __rel_dyn_start (OVERLAY) : {
> +	.bss : {
> +		. = ALIGN(4);
>  		__bss_start = .;
> -		*(.bss)
> -		 . = ALIGN(4);
> +		*(.bss*)
> +		. = ALIGN(4);
>  		__bss_end__ = .;
>  	}
>  
> -	/DISCARD/ : { *(.bss*) }
> +	_end = .;
> +
>  	/DISCARD/ : { *(.dynstr*) }
>  	/DISCARD/ : { *(.dynsym*) }
>  	/DISCARD/ : { *(.dynamic*) }

However, these change fix another issue. You want to cleanup
u-boot-spl.lds, but then there are some other parts I cannot understand.
For example, why is __u_boot_cmd_start = needed ?

If your goal is to cleanup the linker file, please submit a separate
patch removing also the unused sections in SPL.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================