[U-Boot] IXP42x patch series version 3

Graeme Russ graeme.russ at gmail.com
Mon Feb 7 21:54:19 CET 2011


On Tue, Feb 8, 2011 at 7:37 AM, Michael Schwingen
<rincewind at discworld.dascon.de> wrote:
> Am 02/05/2011 12:52 AM, schrieb Wolfgang Denk:
>> Dear Michael Schwingen,
>>
>> In message <1296860763-16149-1-git-send-email-michael at schwingen.org> you wrote:
>>> here is the third incarnation of the IXP patch series. I hope I addressed
>>> all the comments from version 2:
>>>  - timer system now uses no BSS-based variables
>>>  - use I/O accessors
>>>  - remove config.mk from board directories
>>>  - set -ffunction-sections/--gc-sections globally (for IXP architecture)
>> Sorry, but please consider it all NAKed.
>>
>> See the note at bullet 2 at
>> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
>> for the rationale.
> Hi,
>
> I just tried, but I can't find a way to insert the changelog so that
> git-send-email places it at the required point (ie. after the s.o.b. and
> inside the same comment block as the diffstat) - all I could get was the
> changelog inside the comment block, with a line with "---" above, like this:
>
> From: Michael Schwingen <michael at schwingen.org>
> Date: Fri, 4 Feb 2011 21:34:59 +0100
> Subject: [PATCH 01/17] add XScale sub architecture (IXP/PXA) to
> maintainer list
>
> ---
> Changes for V2:
> Changes for V3:
>  - change patch description
>  - drop wepep250 (should already be deleted)
> Changes for V4:
>  - add changelog
>
> Signed-off-by: Michael Schwingen <michael at schwingen.org>
> ---
>  MAINTAINERS |   44 ++++++++++++++++++++++----------------------
>  1 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b37ed0c..709c5d9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -559,8 +559,8 @@ Stefano Babic <sbabic at denx.de>
>
> which looks quite different from what the wiki suggests.
>
> Do you have a short pointer how to get the right result using git? Or is
> this format actually acceptable?
>

I use git-format-patch to dump the patches into a directory and then tweak
the comment section manually before using git-send-email. I can also run
diff against any two versions of the series, checkpatch etc

Maybe there is a more integrated way, but I'm a creature of habit - once I
find something that works for me, I tend to stick to it :)

Regards,

Graeme


More information about the U-Boot mailing list