[U-Boot] {Spam?} u-boot-usb DFU working but need some ideas

Marcel korgull at home.nl
Fri Feb 11 19:30:19 CET 2011


Hi Wolfgang,

> In message <201102102015.59437.korgull at home.nl> you wrote:
> > The GPBR is optional in my code. I just use it because it's the nicest
> 
> > solution for me over the following options :
> I haven't seen your code yet, so I may misunderstand what you are
> actually referring to, but from what it sounds I think that should
> not be optional, but strictly separate from the DFU code.

It is separate or I will make sure it is when I post it.
 
> > Do you mean separate patches to add for example the sam9g45 USB
> > controller and another patch to add DFU and another one to add my board
> > ?
> 
> Yes.

OK.

> > It does make sense to that, I just wonder how to generate those
> > patches...... I know which files I want to include in separate patches,
> > but how do I do that ?
> 
> Normally you do this when developing the code.

Than I just check out a new u-boot-usb and port my code in there in order of 
the patches. It sounds not very difficult and at least makes sure I have several 
patches created the way it should.

> If you already have alltogehter as a huge pile of a mess, then you
> will have to go thtrough splitting this up.  Either completely
> manually (ouch...) or by using git's interactive capabilities - for
> example, "git add --interactive" can be used to select even single
> lines from hunks of changes into the next commit.
> 
> Yes, this is a painful work, but it needs to be done to make your code
> acceptable for mainline.

Understood.
I will go for the manual way as I didn't do much changes to the existing u-
boot code anyway. It's a fairly clean implementation so I should be finished 
with in a couple of hours I think.

I'll post the items this weekend. 

Thanks for all the help so far,
Marcel









More information about the U-Boot mailing list