[U-Boot] [PATCH v4 1/4] Refactor do_reset() into board-specific and CPU-specific portions

[Wolfgang Denk]

Dear "Moffett, Kyle D",

In message <E379DE2E-DDED-45AD-B44B-8006D883F407 at boeing.com> you wrote:
>
> Perhaps the default should instead be something like this?
> 
>   __attribute__((__weak__)) int arch_reset(void)
>   {
>           while(1);
>   }

No. Please don;t implement something that does not do what it is
supposed to do. Rather make the problem obvious.

> Having a default might make it easier to do the initial standup of a new CPU
> type (less code to write initially), but you wouldn't get any obvious errors
> about the fact that you are missing functionality.

That's a fundamentally broken approach.  You know how people work:
they start, they have something running without too blatant error
messages, they leave it as is and go on to the next task.

I rather see a clear unresolved external reference error instead of a
bad defualt that doesn't work.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is no distinctly American criminal class except Congress."
- Mark Twain