[U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

[Wolfgang Denk]

Dear Christopher Harvey,

In message <20110704185554.GH3016 at harvey-pc.matrox.com> you wrote:
> On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote:
> > On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote:
> > > Signed-off-by: Christopher Harvey <charvey at matrox.com>
> > > ---
> > >  arch/arm/lib/board.c |    4 ++++
> > >  arch/arm/lib/bootm.c |    6 ++++++
> > >  2 files changed, 10 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> > > index 169dfeb..dbb835a 100644
> > > --- a/arch/arm/lib/board.c
> > > +++ b/arch/arm/lib/board.c
> > > @@ -404,6 +404,10 @@ void board_init_f (ulong bootflag)
> > >  	post_bootmode_init();
> > >  	post_run (NULL, POST_ROM | post_bootmode_get(0));
> > >  #endif
> > > +	/* 0xffffffff is used to mark is value as "unset".
> > 
> > s/mark is/mark a/
> 
> Yes, what I meant was:
> 0xffffffff is used to mark a value as "unset".

But this is wrong.  It is not unset (= undefined), it is set.
More specifically, it is set to an illegal value.


> > Also, shouldn't the compile fail in this case (#error)?  Or, at least #warn?
> The compiler can't know what machid will be at runtime. Maybe a "would
> you like to continue?" prompt could work.

No. Just print a warning message, and continue.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To know how another being, another creature feels -  that  is  impos-
sible.                  - Terry Pratchett, _The Dark Side of the Sun_