[U-Boot] [PATCH 4/4] Armada100: Adds support for USB on gplugD

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Monday, July 11, 2011 10:15 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [PATCH 4/4] Armada100: Adds support for USB on gplugD
> 
> Hi Prafulla,
> 
> You mean file names should be like uad_u2h.c or armd_u2h.c?

Avoid top posting
See my comments inlined.

> 
> Thanks again.
> 
> Regards,
> Ajay Bhargav
> 
> ----- Original Message -----
> From: "Prafulla Wadaskar" <prafulla at marvell.com>
> To: "Ajay Bhargav" <ajay.bhargav at einfochips.com>
> Cc: u-boot at lists.denx.de, "Ashish Karkare" <akarkare at marvell.com>,
> "Prabhanjan Sarnaik" <sarnaik at marvell.com>
> Sent: Friday, July 8, 2011 8:56:53 PM
> Subject: RE: [PATCH 4/4] Armada100: Adds support for USB on gplugD
> 
> 
> 
> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > Sent: Friday, July 08, 2011 11:53 AM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Ajay Bhargav
> > Subject: [PATCH 4/4] Armada100: Adds support for USB on gplugD
> >
> > Signed-off-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> > ---
> >  arch/arm/cpu/arm926ejs/armada100/Makefile          |    1 +
> >  arch/arm/cpu/arm926ejs/armada100/cpu.c             |   14 ++
> >  arch/arm/cpu/arm926ejs/armada100/pxa168_u2h.c      |  154
> > ++++++++++++++++++++
> >  arch/arm/include/asm/arch-armada100/cpu.h          |   31 ++++
> >  .../include/asm/arch-armada100/pxa168_usb_phy.h    |  115
> > +++++++++++++++
> >  drivers/usb/host/Makefile                          |    1 +
> >  drivers/usb/host/ehci-pxa168.c                     |   58 ++++++++
> 
> The file name should be mv_ehci.c
> 
> >  include/configs/gplugd.h                           |   20 +++
> >  8 files changed, 394 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/cpu/arm926ejs/armada100/pxa168_u2h.c

Any file in this folder should not contain soc-name prefix, if it targeted to specific SOC in that family it should start with armada100_<peripheral>.c/h

> >  create mode 100644 arch/arm/include/asm/arch-
> armada100/pxa168_usb_phy.h

Same here..

> >  create mode 100644 drivers/usb/host/ehci-pxa168.c

This should be preferably mv_ehci.c/h if it is not generic then mv_armava100.c/h

Remember any driver here should be designed more generic way so that it can be supported for other SoCs in that family


Regards..
Prafulla . .