[U-Boot] [PATCH v1 (WIP) 04/16] [Timer]Allow reset_timer() only for Nios2

[Wolfgang Denk]

Dear Graeme Russ,

In message <1309261269-4363-5-git-send-email-graeme.russ at gmail.com> you wrote:
> 
> Signed-off-by: Graeme Russ <graeme.russ at gmail.com>
> ---
>  drivers/block/mg_disk.c |    2 ++
>  drivers/mtd/cfi_flash.c |    4 ++++
>  2 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
> index b74307a..2198017 100644
> --- a/drivers/block/mg_disk.c
> +++ b/drivers/block/mg_disk.c
> @@ -91,7 +91,9 @@ static unsigned int mg_wait (u32 expect, u32 msec)
>  	u32 from, cur, err;
>  
>  	err = MG_ERR_NONE;
> +#ifdef CONFIG_NIOS2
>  	reset_timer();
> +#endif

I don't think this is a good idea.  Instead of making this depend on a
specific architecture, we should make it depend on some feature.

I. e. please change "#ifdef CONFIG_NIOS2" into some "#ifdef
CONFIG_BROKEN_TIMERS" or CONFIG_TERRIBLY_SLOW_CLOCK or the like.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"At least they're __________EXPERIENCED incompetents"