[U-Boot] [PATCH] I2C: mxc_i2c rework

[Marek Vasut]

On Wednesday, July 13, 2011 03:56:45 PM Stefano Babic wrote:
> On 07/13/2011 11:53 AM, Marek Vasut wrote:
> > Rewrite the mxc_i2c driver.
> > 
-- snip --
> > -	while (!(readw(I2C_BASE + I2SR) & I2SR_IBB) && --timeout)
> > +	while (timeout--) {
> > +		if (readb(I2C_BASE + I2SR) & I2SR_IIF) {
> 
> If we wait for completion, should we not check the ICF bit instead of
> IIF, as done before your patch ?

Hi,

Stefano, for some reason, when I check for ICF, the i2c driver doesn't work. 
With IIF it does (and when IIF is asserted, so is ICF). Maybe ICF is asserted 
earlier or who knows.
> 
> > +/*
> > + * Start the controller
> > + */

-- snip --