[U-Boot] [PATCH] ARM: MX5: Remove broken leftover TO-2 errata workaround

[Stefano Babic]

On 07/14/2011 12:20 PM, David Jander wrote:

>> However, you also remove the setup for TO2. To fix the TO2 issue, we
>> should read correctly the revision number (from IIM or from a fixed
>> address, I do not remember now), and then apply the compare to the read
>> value.
> 
> Yes, you are right.
> But I don't know how to do it correctly.

There is a similar code always in lowlevel_init.S

189         ldr r1, =0x0
190         ldr r3, [r1, #ROM_SI_REV]
191         cmp r3, #0x10

As we can suppose this is correct, the same code can be used in the macro.

> OTOH, it is broken now for all platforms.

Agree we have to fix it. I only dislike to break some boards. As far as
I know, there is many mx51evk boards sold by Freescale with the TO2 chip.

> My patch fixes it for TO3 and
> newer. L2 write-combine has a significant performance impact, and I wonder how
> many boards there are still that use such an old (prototype silicon) processor.

I think only on the evaluation boards, but they were sold and delivered.

> IMHO, the vast majority of MX51 users will benefit from this patch, and the
> rest shouldn't have any more problems than they have already, so can we just
> apply this, please?

Not as it is  - I prefer we fix the test. Can you resubmit with the
proposed changes ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================