[U-Boot] [PATCH] integrator: convert to new build system

Wolfgang Denk wd at denx.de
Tue Jul 19 22:04:41 CEST 2011


Dear Linus Walleij,

In message <1311086967-21406-1-git-send-email-linus.walleij at linaro.org> you wrote:
> This deletes the integrator split_by_variant.sh script and
> defines a number of unique board types for the core modules
> that are meaningful to support for the Integrator AP/CP, i.e.
> the ones that did not just say "unsupported core module" in
> split_by_variant.sh. If more core modules need to be supported
> they are easy to add.
> 
> We delete all the old cruft in Makefile and MAKEALL that was
> working around the old way of building boards. We create a
> unique config file per board to satisfy the build system, but
> they are just oneliners that include the existing
> integratorap.h and integratorcp.h configs.
> 
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> This patch goes on top of the previous git pull request and fix
> the final request from Wolfgang to convert the Integrator boards
> over to the new build system.

Thanks a lot.  I have one question, though:

>  include/configs/integratorap.h              |    3 +
>  include/configs/integratorap_cm720t.h       |    1 +
>  include/configs/integratorap_cm920t.h       |    1 +
>  include/configs/integratorap_cm926ejs.h     |    1 +
>  include/configs/integratorap_cm946es.h      |    1 +
>  include/configs/integratorcp.h              |    2 +
>  include/configs/integratorcp_cm1136.h       |    1 +
>  include/configs/integratorcp_cm920t.h       |    1 +
>  include/configs/integratorcp_cm926ejs.h     |    1 +
>  include/configs/integratorcp_cm946es.h      |    1 +

It appears that all the new board config files just include
integrator[ac]p.h, without any additional stuff.   Would it not make
sense to omit these file alltogether then, and let the entries in
boards.cfg point to the generic files integratorap.h resp.
integratorcp.h instead?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Systems programmers are the high priests of a low cult.
                                                       -- R.S. Barton


More information about the U-Boot mailing list