[U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup

[Mehresh Ramneek-B31383]

Hi Kim,

I just checked that this error comes when you don't have any of the following defined in the board file:
CONFIG_USB_UHCI
CONFIG_USB_OHCI
CONFIG_USB_EHCI
CONFIG_USB_OHCI_NEW
...
MPC837xRDB has EHCI host controller. Hence, CONFIG_USB_EHCI and its relevant support macros should be defined in include/configs/MPC837XERDB.h file.

This support is missing from MPC837XERDB.h file. If you include EHCI support inside this file, this error won't come.

So I think option (a) makes more sense, that USB should be configured in all boards using it.

Regards,
Ramneek

-----Original Message-----
From: Phillips Kim-R1AAHA 
Sent: Wednesday, July 20, 2011 1:09 AM
To: Gala Kumar-B11780
Cc: Mehresh Ramneek-B31383; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup

On Thu, 30 Jun 2011 20:25:02 -0500
Kumar Gala <kumar.gala at freescale.com> wrote:

> 
> On Jun 8, 2011, at 6:44 AM, Ramneek Mehresh wrote:
> 
> > Modify support for USB mode fixup:
> >        - Add common support for USB mode and phy type
> >          device tree fix-up for all USB controllers
> >          mentioned in hwconfig string
> >        - Fetch USB mode and phy type via hwconfig; if not
> >          defined in hwconfig, then fetch them from env
> > 
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh at freescale.com>
> > ---
> > arch/powerpc/cpu/mpc8xxx/fdt.c |   77 +++++++++++++++++++++++++++++++++------
> > 1 files changed, 65 insertions(+), 12 deletions(-)
> 
> applied to 85xx

turns out this commit (72f4980) breaks some 83xx boards:

$ ./MAKEALL MPC837XERDB
Configuring for MPC837XERDB board...
/home/r1aaha/git/u-boot/include/usb.h:159:2: error: #error USB Lowlevel not defined
In file included from fdt.c:34:0:
/home/r1aaha/git/u-boot/include/usb.h:159:2: error: #error USB Lowlevel not defined
make[1]: *** [fdt.o] Error 1

it adds a USB-configured dependency by including usb.h in
arch/powerpc/cpu/mpc8xxx/fdt.c, presumably just to get the
USB_MAX_DEVICE constant.

There are multiple ways to fix:

a. configure USB in all boards that don't have it configured,
b. repurpose CONFIG_HAS_FSL_DR_USB to also configure USB,
c. remove #error USB Lowlevel not defined from usb.h,
d. hardcode USB_MAX_DEVICE in fdt.c,
e. have fdt.c loop only over existing usb nodes in the device tree.

my personal preference is e.  What do you think?

Kim