[U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

[Mike Frysinger]

On Thu, Jul 21, 2011 at 01:39, Ajay Bhargav wrote:
> +char gpio_names[MV_MAX_GPIO][GPIO_LABEL_MAX];

probably want to be static ... and this functionality is optional if
you want to just ignore the labels.  for Blackfin gpio, i make it a
build option (useful for debug, not so much for production).

> +static int get_gpio_base(int bank)

if this returned a "struct gpio_reg *", you wouldnt need to cast
everything else below ...
-mike