[U-Boot] [PATCH v2 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

[Lei Wen]

Hi Ajay,

On Fri, Jul 22, 2011 at 3:16 PM, Ajay Bhargav
<ajay.bhargav at einfochips.com> wrote:
> This patch adds support for generic GPIO driver framework for Marvell
> SoC Armada100.
>
> Signed-off-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> ---
>  arch/arm/include/asm/arch-armada100/armada100.h |    4 +
>  arch/arm/include/asm/arch-armada100/gpio.h      |   95 +++++++++++++++++++++++
>  2 files changed, 99 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-armada100/gpio.h
>
> diff --git a/arch/arm/include/asm/arch-armada100/armada100.h b/arch/arm/include/asm/arch-armada100/armada100.h
> index d5d125a..aad3ed1 100644
> --- a/arch/arm/include/asm/arch-armada100/armada100.h
> +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> @@ -59,6 +59,10 @@
>  #define ARMD1_MPMU_BASE                0xD4050000
>  #define ARMD1_APMU_BASE                0xD4282800
>  #define ARMD1_CPU_BASE         0xD4282C00
> +#define ARMD1_GPIO0_BASE       0xD4019000
> +#define ARMD1_GPIO1_BASE       0xD4019004
> +#define ARMD1_GPIO2_BASE       0xD4019008
> +#define ARMD1_GPIO3_BASE       0xD4019100
>
>  /*
>  * Main Power Management (MPMU) Registers
> diff --git a/arch/arm/include/asm/arch-armada100/gpio.h b/arch/arm/include/asm/arch-armada100/gpio.h
> new file mode 100644
> index 0000000..0593b13
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-armada100/gpio.h
> @@ -0,0 +1,95 @@
> +/*
> + * (C) Copyright 2011
> + * eInfochips Ltd. <www.einfochips.com>
> + * Written-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> + *
> + * (C) Copyright 2010
> + * Marvell Semiconductor <www.marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#ifndef _ASM_ARCH_GPIO_H
> +#define _ASM_ARCH_GPIO_H
> +
> +#include <asm/types.h>
> +#include <asm/arch/armada100.h>
> +
> +#define GPIO_TO_REG(gp)                (gp >> 5)
> +#define GPIO_TO_BIT(gp)                (1 << (gp & 0x1F))
> +#define GPIO_VAL(gp, val)      ((val >> (gp & 0x1F)) & 0x01)
> +
> +#define GPIO_SET               1
> +#define GPIO_CLR               0
> +
> +/*
> + * GPIO register map
> + * Refer Datasheet Appendix A.36
> + */
> +struct gpio_reg {

Why not put this structure into driver file?
I think this register is not easy to change, and put this into arch .h
would make the work duplicated,
as each arch need to redefine the same structure again.


> +static inline struct gpio_reg *get_gpio_base(int bank)

After put the structure into the driver file, you could simply return
void* instead of gpio_reg*.

Best regards,
Lei