[U-Boot] [PATCH V3 5/5] devkit8000: Add nand-spl support for new SPL

Simon Schwarz simonschwarzcor at googlemail.com
Tue Jul 26 14:34:58 CEST 2011


Dear Andreas,

On 07/26/2011 12:42 PM, Andreas Bießmann wrote:
> Dear Simon,
>

<snip>

>> diff --git a/board/timll/devkit8000/devkit8000.c b/board/timll/devkit8000/devkit8000.c
>> index 95afaaa..9b53742 100644
>> --- a/board/timll/devkit8000/devkit8000.c
>> +++ b/board/timll/devkit8000/devkit8000.c
>> @@ -119,7 +119,7 @@ void set_muxconf_regs(void)
>>   	MUX_DEVKIT8000();
>>   }
>>
>> -#ifdef CONFIG_DRIVER_DM9000
>> +#if defined(CONFIG_DRIVER_DM9000)&  !defined(CONFIG_SPL_BUILD)
>>   /*
>>    * Routine: board_eth_init
>>    * Description: Setting up the Ethernet hardware.
>> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
>> index 125c690..22c9b8e 100644
>> --- a/include/configs/devkit8000.h
>> +++ b/include/configs/devkit8000.h
>> @@ -307,4 +307,50 @@
>>   		                                         CONFIG_SYS_INIT_RAM_SIZE - \
>>   		                                         GENERATED_GBL_DATA_SIZE)
>>
>> +/* SRAM config */
>> +#define CONFIG_SYS_SRAM_START              0x40200000
>> +#define CONFIG_SYS_SRAM_SIZE               0xFFFF
>
> you mentioned this as 'Changed' in your reply to my last review. It is
> still unchanged (but comment about 64kB removed, so is the size not 64kB?).

Sorry, my mistake. NOW corrected in V4.

> regards
>
> Andreas Bießmann

Regards
Simon


More information about the U-Boot mailing list