[U-Boot] [PATCH] panic: add noreturn attribute

Wolfgang Denk wd at denx.de
Wed Jul 27 14:24:46 CEST 2011


Dear Mike Frysinger,

In message <20110726145430.3E637138EED4 at gemini.denx.de> I wrote:
> 
> In message <1309384684-26415-1-git-send-email-vapier at gentoo.org> you wrote:
> > Since panic() never returns, we should add an appropriate attribute to
> > let gcc improve optimization around it.
> > 
> > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > ---
> >  include/common.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Applied, thanks.

Arghh... this is causing build warnings for ALL boards:

vsprintf.c: In function 'panic':
vsprintf.c:730: warning: 'noreturn' function does return


Please fix!


[Did you not test this??]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
C++ is the best example of second-system effect since OS/360.


More information about the U-Boot mailing list