[U-Boot] [PATCH][v2] powerpc/85xx: enable USB2 gadget mode for corenet ds board

Kumar Gala kumar.gala at freescale.com
Wed Jul 27 14:18:07 CEST 2011


On Jul 18, 2011, at 1:10 AM, Shaohui Xie wrote:

> to make USB2 worked in gadget mode, we need to set it's 'dr_mode' to
> 'peripheral' in hwconfig, but driver starts scan from 'usb1', it'll break
> if it cannot find 'usb1', so we need to tell driver do not break until it
> scaned all the 'usbx' that the board may have.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie at freescale.com>
> ---
> changes for v2:
> 1. fixed a typo in title.
> 2. Added some details in commit.
> 
> arch/powerpc/cpu/mpc8xxx/fdt.c          |    3 ++-
> board/freescale/corenet_ds/corenet_ds.c |    1 +
> include/configs/corenet_ds.h            |    2 ++
> 3 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu/mpc8xxx/fdt.c
> index d9e3e7e..60cb210 100644
> --- a/arch/powerpc/cpu/mpc8xxx/fdt.c
> +++ b/arch/powerpc/cpu/mpc8xxx/fdt.c
> @@ -164,7 +164,8 @@ void fdt_fixup_dr_usb(void *blob, bd_t *bd)
> 			if (mode_idx < 0 && phy_idx < 0)
> 				printf("WARNING: invalid phy or mode\n");
> 		} else {
> -			break;
> +			if (i > CONFIG_SYS_USB_DEVICE)
> +				break;
> 		}
> 	}

I still dont understand why this is needed.  While we might execute the loop more times than needed, will USB_MAX_DEVICE not cover us?


> 	if (!usb1_defined) {

- k


More information about the U-Boot mailing list