[U-Boot] [PATCH V6 2/5] omap-common: add nand spl support

Simon Schwarz simonschwarzcor at googlemail.com
Thu Jul 28 14:54:42 CEST 2011


Hi Aneesh,

On 07/28/2011 11:58 AM, Aneesh V wrote:
> Hi Simon,
>
> On Thursday 28 July 2011 02:08 PM, Simon Schwarz wrote:
> [snip ..]
>> +
>> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +{
>> + debug("resetting cpu...");
>> + reset_cpu(0);
>> +
>> + return 0;
>> +}
>
> Can you explain the need of this do_reset()? I couldn't figure out
> where it is used in SPL.

Thats odd. I added this because of vsprintf - this calls do_reset() 
which is not included in the SPL. This was in an early stage of SPL and 
OMAP4 patches. Seems this is not needed anymore: will delete it for the 
next version.

> br,
> Aneesh

Regards & thx for the review!
Simon



More information about the U-Boot mailing list