[U-Boot] [PATCH V0] omap-common: move early UART clock setup to s_init

[Simon Schwarz]

Dear Wolfgang Denk,

On 07/28/2011 03:04 PM, Wolfgang Denk wrote:
> Dear Simon Schwarz,
>
> In message<1311844938-17278-2-git-send-email-simonschwarzcor at gmail.com>  you wrote:
>> Moves the early UART clock setup setup_clocks_for_console() from
>> preloader_console_init() to s_init() of OMAP4.
>>
>> Signed-off-by: Simon Schwarz<simonschwarzcor at gmail.com>
>> ---
>>   arch/arm/cpu/armv7/omap-common/spl.c |    1 -
>>   arch/arm/cpu/armv7/omap4/board.c     |    1 +
>>   2 files changed, 1 insertions(+), 1 deletions(-)
>
> I'm unhappy about the subject.  not to mention again that you posted
> another (empty) patch with basicly the same subject line, but you say
> "omap-common:" in the subject, while the code looks to be OMAP4
> specific?  This is kind of misleading.
>
Reason: omap-common because it is a omap-common change - the omap4 part 
is just to fix it up for the SOC which is using it already.

So maybe deleting setup_clocks_for_console() would have been a better 
subject, sorry.

> Best regards,
>
> Wolfgang Denk
>
Regards
Simon Schwarz