[U-Boot] [PATCH] powerpc/eeprom: cleanup mac command

[Wolfgang Denk]

Dear York Sun,

In message <1311869371.29459.11.camel at oslab-l1> you wrote:
> 
> > Why are you turning a generic, board and architecture independent
> > command into a FSL specific one?
> 
> I believe this "generic" command is only for FSL boards. Moving it to
> right place.

Even if it supports only FSL boards at the moemnt, the change should
be in the opposite direction: move all the generic code out of the FSL
directories and make it publicly available so others can use this tool
as well.

> > In case you ever move / rename a file:  please supply the options so
> > git will detect the move / copy / rename.
> 
> The meaningful code was moved into an existing file, so it wasn't
> renaming a file.

That's what you think.  Did you check what git says about it?


So: still NAK.  Please do it the other way round.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.