[U-Boot] [PATCH v7] unify version_string

[Andreas Bießmann]

Dear Wolfgang,

Am 28.07.2011 um 23:09 schrieb Wolfgang Denk:

> Dear Andreas,
> 
> In message <1311869959-6085-1-git-send-email-andreas.devel at googlemail.com> you wrote:
>> 
>> This patch removes the architecture specific implementation of
>> version_string where possible. Some architectures use a special place
>> and therefore we provide U_BOOT_VERSION_STRING definition and a common
>> weak symbol version_string.
> ...
>> - proven to build with MAKEALL for at91rm9200ek and qong
>> - proven to run on at91rm9200ek device
> 
> Please note that it is NOT sufficient to build just two board, and
> then even both of the same architecture!! Please re-read Note # 3 at
> http://www.denx.de/wiki/U-Boot/Patches - it means you should build
> _all_ board in at least two different architectures.

I do only have arm and avr32 compilers therefore I can only test those architecture boards. The patch you applied was there since 2011.06.30 and no one else tested it.

> I believed you, twice.  You didn't, twice.  And you failed, twice.
> 
> Now we get tons of warnings like this:
> 
> cfb_console.c:1497: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[]'

Well, sorry for that, I could have found it cause jadecpu is arm and do use cfb_console.c. I failed to fulfill Note #3 ...

> Please fix!
> 
> [Note: your patch is in mainline, so we need an incremental fix.]

Will do ASAP.

Best regards

Andrea Bießmann