[U-Boot] [PATCH/RFC v4] unify version_string

[Mike Frysinger]

On Wednesday, June 29, 2011 18:32:49 Andreas Bießmann wrote:
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
>
> -const char version_string[] =
> -	U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ")"CONFIG_IDENT_STRING;
> +const char * const version_string = U_BOOT_VERSION_STRING;

two things:
 - why the change to a pointer from an array ?  it wastes a pointer
 - this should be in a common file somewhere marked weak that way the people 
who do it normal (everyone but ppc?) dont have to duplicate it at all, and the 
people who do it oddly (ppc) can still keep doing what they're doing

const char __weak version_string[] = U_BOOT_VERSION_STRING;

> --- a/include/version.h
> +++ b/include/version.h
> 
> +#define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
> +	U_BOOT_TIME ")" CONFIG_IDENT_STRING;

pretty sure that trailing semi-colon doesn't belong
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110629/76f07b0e/attachment.pgp