[U-Boot] AT91: CFI support broken

Reinhard Meyer u-boot at emk-elektronik.de
Fri May 20 13:54:11 CEST 2011


Dear esw at bus-elektronik.de,
> Hello,
>
> since "AT91: fix timer.c - remove reset_timer()"
>
> <http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
>
> was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
>
> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>
> I think this patch should be revert, as long as other modules need the
> reset_timer function.
>
> Can anybody confirm this

I think we should fix the place where reset_timer() is still used, to use get_timer() only.
All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact
that get_timer() is monotonic. reset_timer() resets the value back to zero.

Best Regards,
Reinhard


More information about the U-Boot mailing list