[U-Boot] [PATCH v2 5/8] nand: Merge new implementation of 1-bit ECC from Linux nand driver

Scott Wood scottwood at freescale.com
Tue Nov 1 21:30:32 CET 2011


On 11/01/2011 02:49 AM, Christian Hitz wrote:
> Am 31.10.2011 21:15, schrieb Scott Wood:
>> On 10/31/2011 07:22 AM, Christian Hitz wrote:
>>> Am 29.10.2011 00:30, schrieb Scott Wood:
>>>> On 10/12/2011 02:32 AM, Christian Hitz wrote:
>>>>> [backport from linux commit 02f8c6aee8df3cdc935e9bdd4f2d020306035dbe]
>>>>>
>>>>> This patch synchronizes the nand driver with the Linux 3.0 state.
>>>>>
>>>>> Adds 1416 bytes to the image size.
>>>>
>>>> What does this version of the code do that warrants the code size
>>>> increase?  This could break some SPLs.
>>>>
>>>> If it's just a speed issue, we probably want to stick with the current code.
>>>
>>> It's the rewrite for performance and support for 512 byte pages, but this is
>>> on the basis of the rewritten code.
>>
>> Several SPLs make use of nand_ecc.c, so NACK replacing it with a larger
>> implementation.
> 
> So, should I resubmit the patch series without this part?

Not if the current patchset works with this one dropped.

-Scott



More information about the U-Boot mailing list