[U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board

Mike Frysinger vapier at gentoo.org
Fri Nov 4 23:24:23 CET 2011


i'm not terribly familiar with what it takes to make an x86 board, but i don't 
see anything jumping out of this patch.

i would note however that you should merge the boards.cfg update into this 
patch.  merging one or the other doesn't make much sense, and there's no 
reason to keep them split.

> +void setup_pcat_compatibility()

should be "(void)"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111104/8327e21c/attachment.pgp 


More information about the U-Boot mailing list