[U-Boot] [PATCH v2 1/3] Add limits.h to hold basic limits

[Mike Frysinger]

On Friday 04 November 2011 01:14:08 Simon Glass wrote:
> On Thu, Nov 3, 2011 at 7:33 PM, Mike Frysinger wrote:
> > On Monday 10 October 2011 15:22:29 Simon Glass wrote:
> >> This brings a basic limits.h implementation into U-Boot.
> > 
> > sorry to jump in so late, but i think this was the correct way to go.
> >  copying & pasting the same defines throughout the tree doesn't make
> > much sense.  this would also make it easier to grab changes from Linux
> > since they're the same.
> 
> Well Albert was pretty keen on leaving this out. Next time we need
> INT_MAX somewhere, or see someone defining it in a patch, we can think
> about adding limits.h.

his complaint was that there was one consumer.  we now have two.  and in both 
cases, it's because we imported code from Linux.

i would take the position that even if there is just one consumer (ubifs in 
this case), we should be importing this.  although it might make more sense to 
have this in linux/limits.h.  only downside there is that the upstream Linux 
code (oddly) places these in linux/kernel.h instead of linux/limits.h.  but i 
think i can live with that idiosyncrasy.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111104/9d5bdc43/attachment.pgp