[U-Boot] [PATCH 00/14] Support for HTKW mcx board

Ilya Yanok yanok at emcraft.com
Mon Nov 7 01:00:00 CET 2011


Hi Tom,

03.11.2011 4:33, Tom Rini wrote:
>> these patches introduce support for HTKW mcx board (AM3517-based).
>>
>> Previously posted DaVinci EMAC patches
>> ( http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/112309 )
>> and NAND SPL patches
>> ( http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/112890 )
>> are also included as long as EHCI host support (moved from Beagle
>> board code).
>>
>> Signed-off-by: Ilya Yanok<yanok at emcraft.com>
>
> I'm not sure what we should do about this series right now.  Aside
> from some "easily" fixable things like all of the PHY files needing an
> ugly #include "../../../../../drivers/net/davinci_emac.h" to compile

Shouldn't we use generic PHY layer and move all PHY files to 
drivers/net/phy?

> again and a CONFIG_SYS_CACHELINE_SIZE 32 in all of the platforms, the

s/CONFIG_SYS_CACHELINE_SIZE/ARCH_DMA_MINALIGN/ should solve this 
problem. I'll fix this.

> lack of flush functions means that MAKEALL -s davinci fails for almost
> every board now.  I'm not sure what we should do, at this point...

Argh.. Actually my initial version had a workaround for this, only using 
{flush,invalidate}_dcache_range under #ifdef DAVINCI_EMAC_DCACHE 
clause... But Mike told me that I should remove this...

Maybe we can just add empty functions for CONFIG_DCACHE_OFF case to fix 
the compilation?

Regards, Ilya.




More information about the U-Boot mailing list