[U-Boot] [PATCH] [driver][cfb] Make the software cursor non-destructive

[Mike Frysinger]

On Tuesday 08 November 2011 03:59:29 Gabe Black wrote:
> When printing the string "\r\n" to the framebuffer console, the first
> character of the current line was being replaced with a space. The "boot"
> prompt would become the "oot" prompt. This change makes the cursor
> non-destructive so that no matter where it goes on its way to where it's
> supposed to be, the end result is that the cursor is where it's supposed to
> be with the other text preserved intact.

"preserved intact" ... word for word verbose redundant ? ;)

> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
>
>  /*
>   * Cursor definition:
>   * CONFIG_CONSOLE_CURSOR:  Uses a timer function (see
> drivers/input/i8042.c) 
> - *			   to let the cursor blink. Uses the macros
> - *			   CURSOR_OFF and CURSOR_ON.
> + *			   to let the cursor blink.

is this intentional ?  seems like the existing doc strings are fine ...

> @@ -248,9 +247,9 @@
> 
> -#define CURSOR_ON  console_cursor(1)
> +#define CURSOR_ON console_cursor(1)

unrelated whitespace change

> -#define CURSOR_ON
> -#define CURSOR_OFF video_putchar(console_col * VIDEO_FONT_WIDTH,\
> -				 console_row * VIDEO_FONT_HEIGHT, ' ')
> +void	console_cursor (int state);
> +#define CURSOR_ON console_cursor(1)
> +#define CURSOR_OFF console_cursor(0)
>  #define CURSOR_SET video_set_cursor()

so now the CONFIG_CONSOLE_CURSOR and CONFIG_VIDEO_SW_CURSOR code paths wrt 
CURSOR_* definitions are the same.  seems like they should be unified.

> +static void video_invertchar (int xx, int yy)

no space before that "("

the rest looks fine to me, but let's CC the video maintainer ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111108/1281fd0e/attachment.pgp