[U-Boot] [PATCH v3 2/2] mpc83xx: Implement interrupt support for mpc83xx

Kim Phillips kim.phillips at freescale.com
Wed Nov 9 03:08:20 CET 2011


On Mon, 7 Nov 2011 20:08:49 -0600
Joe Hershberger <joe.hershberger at gmail.com> wrote:

> Hi Kim,
> 
> On Thu, Nov 3, 2011 at 3:48 PM, Kim Phillips <kim.phillips at freescale.com> wrote:
> > On Tue, 11 Oct 2011 21:46:05 -0500
> > Joe Hershberger <joe.hershberger at ni.com> wrote:
> >
> >> Some core ipic code from Linux - commit bbf25010f1a6b761914430f5fca081ec8c7accd1
> >
> > commit bbf25010f1a6b761914430f5fca081ec8c7accd1
> > Author: Linus Torvalds <torvalds at woody.linux-foundation.org>
> > Date:   Tue Oct 9 13:31:38 2007 -0700
> >
> >    Linux 2.6.23
> >
> > ...any particular reason to pull in such an old version?
> 
> That was the current version when I implemented the interrupt support.

well it would have worked back then ;).  A lot of vectors for the
later 83xx SoCs have been added in upstream linux since then.

> >> + */
> >> +#define IPIC_INT_UART1     (0x09)
> >
> > Is it possible to avoid the list altogether somehow?  Use an
> > embedded device tree?  See doc/README.fdt-control.
> 
> Perhaps that is a good long-term approach.  I'm not sure I'm up for
> that retrofit just now.  ;)

understood.  Dropping this table is important because of things like
TSEC IRQ numbers changing in between revisions of the 8313 (see
commit 7120c88 (which doubles as a good example of how to extract
the IRQ numbers from the device tree :)).

Kim



More information about the U-Boot mailing list