[U-Boot] [PATCH] arm, davinci_emac: fixup

Heiko Schocher hs at denx.de
Wed Nov 9 07:56:55 CET 2011


Hello Wolfgang,

Wolfgang Denk wrote:
> Dear Heiko Schocher,
> 
> In message <1320819979-3861-1-git-send-email-hs at denx.de> you wrote:
> ...
>> +			if (count < MAX_PHY)
>> +				active_phy_addr[j++] = i;
>> +			else {
>> +				printf("%s: to much PHYs detected.\n",
>> +					__func__);
>> +				break;
>> +			}
> 
> Coding Style: if the "else" branch uses braces, the "if" branch shall
> use braces, too.

Hups, you are right, just checked only with checkpatch ... sorry.
Changed!

> Also, please s/too much/too many/  in the printf() above.

Done.

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list