[U-Boot] [PATCH v3] arm, davinci_emac: fix driver bug if more then 3 PHYs are detected

Heiko Schocher hs at denx.de
Thu Nov 10 05:43:41 CET 2011


Hello Tom,

Tom Rini wrote:
> On Wed, Nov 9, 2011 at 9:50 AM, Heiko Schocher <hs at denx.de> wrote:
>> since commits:
>> davinci: emac: add support for more than 1 PHYs
>> 062fe7d332c28ede25626f448681e43d76bb312e
>>
>> davinci: remove obsolete macro CONFIG_EMAC_MDIO_PHY_NUM
>> fb1d6332b5430b90a8fa8ebab709f33a60e9f816
> [snip]
>> - MAX_PHY from 3 to 7
> 
> Why don't we add a CONFIG here and default to 3, ie
> #ifndef CONFIG_SYS_something
> #define CONFIG_SYS_something 3
> #endif

Do we really need a config option for this? Why 3 or 7 as I did?
Shouldn't we set this define to 32, as this is the max possible
PHYs? Ok, we loose some RAM with this option ...

Would CONFIG_SYS_DAVINCI_EMAC_PHY_COUNT a good name?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list