[U-Boot] [PATCH v3 06/12] OMAP3: Suffix all Micron memory timing parts with their speed

[Heiko Schocher]

Hello Tom,

Tom Rini wrote:
> Signed-off-by: Tom Rini <trini at ti.com>
> ---
>  arch/arm/include/asm/arch-omap3/mem.h |   50 +++++++++++++++++----------------
>  1 files changed, 26 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-omap3/mem.h b/arch/arm/include/asm/arch-omap3/mem.h
> index 9775b59..4d69c94 100644
> --- a/arch/arm/include/asm/arch-omap3/mem.h
> +++ b/arch/arm/include/asm/arch-omap3/mem.h
> @@ -144,28 +144,30 @@ enum {
>  		ACTIM_CTRLB(MICRON_TWTR_165, MICRON_TCKE_165,	\
>  				MICRON_TXP_165,	MICRON_XSR_165)
>  
> -#define MICRON_RAMTYPE			0x1
> -#define MICRON_DDRTYPE			0x0
> -#define MICRON_DEEPPD			0x1
> -#define MICRON_B32NOT16			0x1
> -#define MICRON_BANKALLOCATION	0x2
> -#define MICRON_RAMSIZE			((PHYS_SDRAM_1_SIZE/(1024*1024))/2)
> -#define MICRON_ADDRMUXLEGACY	0x1
> -#define MICRON_CASWIDTH			0x5
> -#define MICRON_RASWIDTH			0x2
> -#define MICRON_LOCKSTATUS		0x0
> -#define MICRON_V_MCFG ((MICRON_LOCKSTATUS << 30) | (MICRON_RASWIDTH << 24) | \
> -	(MICRON_CASWIDTH << 20) | (MICRON_ADDRMUXLEGACY << 19) | \
> -	(MICRON_RAMSIZE << 8) | (MICRON_BANKALLOCATION << 6) | \
> -	(MICRON_B32NOT16 << 4) | (MICRON_DEEPPD << 3) | \
> -	(MICRON_DDRTYPE << 2) | (MICRON_RAMTYPE))
> -
> -#define MICRON_BL				0x2
> -#define MICRON_SIL				0x0
> -#define MICRON_CASL				0x3
> -#define MICRON_WBST				0x0
> -#define MICRON_V_MR ((MICRON_WBST << 9) | (MICRON_CASL << 4) | \
> -	(MICRON_SIL << 3) | (MICRON_BL))
> +#define MICRON_RAMTYPE_165		0x1
> +#define MICRON_DDRTYPE_165		0x0
> +#define MICRON_DEEPPD_165		0x1
> +#define MICRON_B32NOT16_165		0x1
> +#define MICRON_BANKALLOCATION_165	0x2
> +#define MICRON_RAMSIZE_165		((PHYS_SDRAM_1_SIZE/(1024*1024))/2)
> +#define MICRON_ADDRMUXLEGACY_165	0x1
> +#define MICRON_CASWIDTH_165		0x5
> +#define MICRON_RASWIDTH_165		0x2
> +#define MICRON_LOCKSTATUS_165		0x0
> +#define MICRON_V_MCFG_165		((MICRON_LOCKSTATUS_165 << 30) | \
                                                                   ^
Please substitute this magic values in this patch by an define.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany