[U-Boot] [PATCH 04/12] drivers/net/enc28j60.c: Fix GCC 4.6 warnings

Wolfgang Denk wd at denx.de
Wed Nov 16 21:30:17 CET 2011


Dear Mike Frysinger,

In message <201111161058.57150.vapier at gentoo.org> you wrote:
>
> On Tuesday 15 November 2011 18:20:55 Anatolij Gustschin wrote:
> > -		eir_reg = enc_r8(enc, CTL_REG_EIR);
> > +		(void)enc_r8(enc, CTL_REG_EIR);
>
> is that (void) actually necessary ?  last i looked, gcc didn't actually care.  
> which means you should drop the (void).

It's not really necessary, but always a good indication to the reader
that we intentionally ignore the return code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of  trouble  to  go  to
just sharpen a razor blade.  - Terry Pratchett, _The Light Fantastic_


More information about the U-Boot mailing list