[U-Boot] [PATCH 3/4] arm, omap3: Add support for TechNexion modules

[Wolfgang Denk]

Dear Tapani Utriainen,

In message <20111121164800.23d1025f at myhost> you wrote:
> 
> Add support for TechNexion TAO3530 SoM

Same comments as for previous module.

Also again: please chose a beter Subject: line.

...
> +	/* Set memory size environment variable, depending on revision */
> +	switch (tao3530_revision()) {
> +	case 0x2:  /* Rev C1 -- 256MB */
> +		 setenv("mem_size", "mem=256M");
> +		 break;
> +	default:
> +		 printf("Warning: Unknown TAO3530 rev, setting mem=128M\n");
> +	case 0x3: /* Rev A2/B2 -- 128MB */
> +		 setenv("mem_size", "mem=128M"); break;
> +		 break;

Please don't hard-wire memory sizes.  Use get_ram_size() to
auto-detect the actual size on the module.

...
> +	/* Make GPIO 142 as output pin */
> +	writel(readl(&gpio5_base->oe) & ~(GPIO14), &gpio5_base->oe);
> +
> +	/* Now send a pulse on the GPIO pin */

Please add comments why actions like these are needed / what they are
good for.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HANDLE WITH EXTREME CARE:  This Product Contains  Minute Electrically
Charged  Particles  Moving  at  Velocities  in Excess of Five Hundred
Million Miles Per Hour.