[U-Boot] [RFC PATCH v2 12/12] arm, davinci: Add support for generating AIS images to the Makefile

[Mike Frysinger]

On Monday 21 November 2011 11:33:47 Christian Riesch wrote:
> --- a/Makefile
> +++ b/Makefile
>
> +$(obj)u-boot.ais:       $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin
> +		$(obj)tools/mkimage -s -n /dev/null -T aisimage \
> +		-e $(CONFIG_SPL_TEXT_BASE) -d $(obj)spl/u-boot-spl.bin \
> +		$(obj)spl/u-boot-spl.ais
> +		$(OBJCOPY) ${OBJCFLAGS} -I binary --pad-to=$(PAD_TO) -O binary
> $(obj)spl/u-boot-spl.ais $(obj)spl/u-boot-spl-pad.ais +		cat
> $(obj)spl/u-boot-spl-pad.ais $(obj)u-boot.bin > $(obj)u-boot.ais +		rm
> $(obj)spl/u-boot-spl.ais
> +		rm $(obj)spl/u-boot-spl-pad.ais
> +

can't this live in arch/arm/.../config.mk somewhere ?

> --- /dev/null
> +++ b/board/davinci/da8xxevm/config.mk
>
> +# required for SPI flash SPL
> +#
> +
> +PAD_TO	:= 32768

"PAD_TO" is way too generic a name.  this should also be a CONFIG_XXX define in 
the board config header rather than using config.mk.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111121/c0818339/attachment.pgp>