[U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef

Marek Vasut marek.vasut at gmail.com
Wed Nov 23 11:44:49 CET 2011


> On 23/11/2011 03:48, Jason Hui wrote:
> > From the u-boot/README:
> > 
> > * Configuration _OPTIONS_:
> >   These are selectable by the user and have names beginning with
> >   "CONFIG_".
> > 
> > * Configuration _SETTINGS_:
> >   These depend on the hardware etc. and should not be meddled with if
> >   you don't know what you're doing; they have names beginning with
> >   "CONFIG_SYS_".
> > 
> > It's better to use #define CONFIG_SYS_MXC_UART_BASE   UART1_BASE
> > 
> > [...]
> 
> Agree, I do it in V2
> 
> Best regards,
> Stefano Babic

But this is not completely right. Why CONFIG_SYS, if the user can change it 
quite safely to adjust his serial port.

M


More information about the U-Boot mailing list