[U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions

[Remy Bohmer]

Hi,

2011/10/17 Marek Vasut <marek.vasut at gmail.com>:
> On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote:
>> Signed-off-by: Stefan Herbrechtsmeier <sherbrec at cit-ec.uni-bielefeld.de>
>> CC: Marek Vasut <marek.vasut at gmail.com>
>> CC: Remy Bohmer  <linux at bohmer.net>
>> ---
>
> Hi Stefan,
>
> this patch is awesome, I really need this one. But ...
>
> Can you possibly convert the register definitions to struct based access ?
>
> Like
>
> struct pxa_usb_regs {
> u32 reg1;
> u32 reg2;
> ...
> };
>
> and then use it in the functions :
>
> type fn()
> {
>        struct pxa_usb_regs regs = (struct pxa_usb_regs)0x46000000;
> ...
>        writel(val, &regs->reg1);
> }

I agree with this remark, but I think this should be done in a different patch.

So, I applied it to u-boot-usb as-is.

Kind regards,

Remy