[U-Boot] [RFC/PATCH] davinci: disable dcache on boards with EMAC

Wolfgang Denk wd at denx.de
Sun Nov 27 16:09:22 CET 2011


Dear Ilya Yanok,

In message <1321048618-20616-1-git-send-email-yanok at emcraft.com> you wrote:
> DaVinci EMAC driver has no support for running with D-Cache enabled so
> disable D-Cache on all DaVinci boards with EMAC device.
> 
> Signed-off-by: Ilya Yanok <yanok at emcraft.com>
> ---
> 
> I can't test it on any DaVinci boards right now but my understanding
> is that currently EMAC driver can't work properly with D-Cache enabled.
> 
>  include/configs/da830evm.h          |    1 +
>  include/configs/davinci_dm365evm.h  |    1 +
>  include/configs/davinci_dm6467evm.h |    1 +
>  include/configs/davinci_dvevm.h     |    1 +
>  include/configs/davinci_schmoogie.h |    1 +
>  include/configs/davinci_sffsdr.h    |    1 +
>  include/configs/davinci_sonata.h    |    1 +
>  include/configs/ea20.h              |    1 +
>  include/configs/hawkboard.h         |    1 +
>  9 files changed, 9 insertions(+), 0 deletions(-)

Why do we have to permanently disable the data cache just because the
network driver is broken?  USB is also broken, and probably other
drivers as well.

But this does not man we cannot use the data cache for other things.
Actually we WANT to be able to use it, so it is counter-productive to
disable it.

It should be sufficient to switch the cache off ("dc off") before
runnign any network related commands (and you want to make sure to
switch it on again afterwards).


Please PLEASE stop disabling cache support in the config files!

Rather invest efforts in fixing the broken drivers.

Thanks.


[In case it was not clear:  This is a NAK.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Die Freiheit des Menschen liegt nicht darin, dass er tun kann, was er
will, sondern darin, dass er nicht tun muss, was er nicht will.
                                             -- Jean-Jacques Rousseau


More information about the U-Boot mailing list