[U-Boot] [PATCH v3 0/3] arm, davinci: add am1808 based enbw_cmc board

[Igor Grinberg]

Hi Heiko,

On 11/28/11 12:44, Heiko Schocher wrote:
> repost from:
> [U-Boot] [PATCH v2 0/3] arm, davinci: add am1808 based enbw_cmc board
> http://lists.denx.de/pipermail/u-boot/2011-October/104399.html
> 
> Following patches are needed for this patchset
> - patchset from Christian Riesch:
> [U-Boot] [PATCH v3 00/15] Add an SPL to boot the da850evm from SPI
> http://lists.denx.de/pipermail/u-boot/2011-November/111182.html
> 
> - [U-Boot,1/2] arm, arm926ejs: always do cpu critical inits
> patchwork.ozlabs.org/patch/124787/
> 
> - [U-Boot] arm, fdt: update ethernet mac address before booting Linux
> http://patchwork.ozlabs.org/patch/114736/
> 
> - [U-Boot] : davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
> http://patchwork.ozlabs.org/patch/114482/
> 
> checkpatch:
> total: 0 errors, 0 warnings, 75 lines checked
> 
> 20111128_ml/0001-arm-davinci-move-davinci_rtc-struct-to-hardware.h.patch has no obvious style problems and is ready for submission.
> total: 0 errors, 0 warnings, 18 lines checked
> 
> 20111128_ml/0002-arm-davinci-da850-add-uart1-tx-rx-pinmux-config.patch has no obvious style problems and is ready for submission.
> WARNING: Use #include <linux/gpio.h> instead of <asm/gpio.h>
> #223: FILE: board/enbw/enbw_cmc/enbw_cmc.c:41:
> +#include <asm/gpio.h>
> 
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #229: FILE: board/enbw/enbw_cmc/enbw_cmc.c:47:
> +#include <asm/io.h>
> 
> WARNING: simple_strtoul is obsolete, use kstrtoul instead
> #610: FILE: board/enbw/enbw_cmc/enbw_cmc.c:428:
> +               sprintf(buf, "%ld", simple_strtoul(s, NULL, 10) + 1);
> 
> ERROR: Macros with multiple statements should be enclosed in a do - while loop
> #951: FILE: include/configs/enbw_cmc.h:99:
> +#define CONFIG_DTT_SENSORS     {0}     /* Sensor addresses             */
> 
> total: 1 errors, 3 warnings, 1168 lines checked
> 
> 20111128_ml/0003-arm-davinci-add-support-for-am1808-based-enbw_cmc-bo.patch has style problems, please review.
> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.

This does not look like tools/checkpatch.pl in current U-Boot source.
Have you tried to use the tools/checkpatch.pl from current U-Boot source?

> 
> Cc: Paulraj Sandeep <s-paulraj at ti.com>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> Cc: Igor Grinberg <grinberg at compulab.co.il>
> Cc: Christian Riesch <christian.riesch at omicron.at>
> 
> Heiko Schocher (3):
>   arm, davinci: move davinci_rtc struct to hardware.h
>   arm, davinci, da850: add uart1 tx rx pinmux config
>   arm, davinci: add support for am1808 based enbw_cmc board
> 
>  MAINTAINERS                                     |    1 +
>  arch/arm/cpu/arm926ejs/davinci/da850_pinmux.c   |    5 +
>  arch/arm/include/asm/arch-davinci/hardware.h    |   39 ++
>  arch/arm/include/asm/arch-davinci/pinmux_defs.h |    1 +
>  board/enbw/enbw_cmc/Makefile                    |   51 ++
>  board/enbw/enbw_cmc/enbw_cmc.c                  |  652 +++++++++++++++++++++++
>  boards.cfg                                      |    1 +
>  drivers/rtc/davinci.c                           |   26 -
>  include/configs/enbw_cmc.h                      |  451 ++++++++++++++++
>  9 files changed, 1201 insertions(+), 26 deletions(-)
>  create mode 100644 board/enbw/enbw_cmc/Makefile
>  create mode 100644 board/enbw/enbw_cmc/enbw_cmc.c
>  create mode 100644 include/configs/enbw_cmc.h
> 

-- 
Regards,
Igor.