[U-Boot] [PATCH] tools/envcrc: fix compile breakage

Wolfgang Denk wd at denx.de
Mon Nov 28 16:15:49 CET 2011


Dear Igor Grinberg,

In message <4ED34E9B.7040200 at compulab.co.il> you wrote:
> 
> > Hm... the fix seems wrong to me.  What happens now if ENV_IS_EMBEDDED
> > is set, but CONFIG_BUILD_ENVCRC is _not_ set?
> 
> Well, you should look into that file...

It's faster for me to ask you to do that :-)

> > Did this change pass a MAKEALL for example for ppc?
> 
> I don't have the tool chain for ppc.
> I think the original fix has been tested by Stefano.
> Is there a requirement to have all the supported
> architectures tool chains, for submitting patches?

Not for all, but http://www.denx.de/wiki/U-Boot/Patches says "Please
also run MAKEALL for _at_least_one_other_architecture_ than the one you
made your modifications in."

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"They that can give up essential liberty to obtain a little temporary
saftey deserve neither liberty not saftey." - Benjamin Franklin, 1759


More information about the U-Boot mailing list