[U-Boot] [PATCH v3 3/3] arm, davinci: add support for am1808 based enbw_cmc board

Wolfgang Denk wd at denx.de
Mon Nov 28 16:42:01 CET 2011


Dear Heiko Schocher,

In message <4ED3A6A8.5010301 at denx.de> you wrote:
> 
> >> +		ret = gpio_request(gpio, enbw_gpio_config[i].name);
> >> +		if (ret)
> >> +			printf("%s: Could not get %s gpio\n", __func__,
> >> +				enbw_gpio_config[i].name);
> >> +		else
> > 
> > instead of having that else and adding another level of indentation below
> > you can just add continue;
> 
> Done.

Is this really a good idea??


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One essential to success is that you desire be an all-obsessing  one,
your thoughts and aims be co-ordinated, and your energy be concentra-
ted and applied without letup.


More information about the U-Boot mailing list