[U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S

Mike Frysinger vapier at gentoo.org
Tue Nov 29 04:15:38 CET 2011


On Monday 21 November 2011 18:58:00 Simon Glass wrote:
> --- a/board/reloc.c
> +++ b/board/reloc.c
>
> -void new_relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
> +void relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)

this is too fragile.  we can't have every arch transition the way you did with 
arm (otherwise arches that have transitioned will break in between).  declare 
this func weak and don't rename it.  then there should be no migration issue.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111128/4f1806d9/attachment.pgp>


More information about the U-Boot mailing list