[U-Boot] [PATCH 2/4] da830: emac: add support for RMII

[Igor Grinberg]

On 09/30/11 18:48, Mike Frysinger wrote:
> On Friday, September 30, 2011 07:57:10 nagabhushana.netagunte at ti.com wrote:
>> --- a/drivers/net/davinci_emac.c
>> +++ b/drivers/net/davinci_emac.c
>> @@ -246,7 +246,7 @@ static int gen_get_link_speed(int phy_addr)
>>  	if (davinci_eth_phy_read(phy_addr, MII_STATUS_REG, &tmp) &&
>>  			(tmp & 0x04)) {
>>  #if defined(CONFIG_DRIVER_TI_EMAC_USE_RMII) && \
> 
> there's a common CONFIG_RMII symbol already ...
> 
>> -		defined(CONFIG_MACH_DAVINCI_DA850_EVM)
>> +		defined(CONFIG_MACH_DAVINCI_DA8XX_EVM)
> 
> maybe it's just me, but board level defines in an emac driver make no sense

No, it is not just you ;)
Davinci EMAC is used also in non davinci SoCs and restricting its
features to some board (or family of boards) indeed makes no sense.
There must be a good reason for doing so, otherwise that board
specific config should be removed.


-- 
Regards,
Igor.