[U-Boot] [PATCH 1/8] PPC: Fix tqm8xx_pcmcia.c by removing condition around pcmp

Wolfgang Denk wd at denx.de
Mon Oct 3 16:26:48 CEST 2011


Dear Marek Vasut,

In message <1317603450-7527-2-git-send-email-marek.vasut at gmail.com> you wrote:
> From: Marek Vasut <marex at pollux.denx.de>

Please make sure to use only valid mail addresses.


> This fix has no impact on u-boot.bin size (tested with ELDK 4.2).
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  drivers/pcmcia/tqm8xx_pcmcia.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

Um... this modification increases the code size;

before (commit b30d41c):

$ size u-boot
   text    data     bss     dec     hex filename
 260519   13960   25704  300183   49497 /work/wd/tmp-ppc/u-boot
$ size drivers/pcmcia/tqm8xx_pcmcia.o
   text    data     bss     dec     hex filename
    655      16       0     671     29f /work/wd/tmp-ppc/drivers/pcmcia/tqm8xx_pcmcia.o

After:

$ size u-boot
   text    data     bss     dec     hex filename
 260543   13960   25704  300207   494af /work/wd/tmp-ppc/u-boot
$ size drivers/pcmcia/tqm8xx_pcmcia.o
   text    data     bss     dec     hex filename
    683      16       0     699     2bb /work/wd/tmp-ppc/drivers/pcmcia/tqm8xx_pcmcia.o

I'm not willing to accept a code size increase (especially when DEBUG
is not even defined!)  for such a change.


Please find a better way to fix the problems introduced by commit
60ce53c... GCC4.6: Convert various empty macros to inline functions



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not follow where the path may lead....go instead where there is no
path and leave a trail.


More information about the U-Boot mailing list