[U-Boot] [PATCH v3 06/21] sandbox: Add architecture lib files

Simon Glass sjg at chromium.org
Tue Oct 4 02:02:59 CEST 2011


Hi Mike,

On Sun, Oct 2, 2011 at 11:15 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday, September 26, 2011 20:10:40 Simon Glass wrote:
>> +     gd->mon_len = 0; /* _bss_end_ofs;*/
>
> i'd scrub references to this and drop it from the global header

OK

>
>> +     size = 128 * 1024 * 1024;
>> +     mem = malloc(size);
>> +     assert(mem);
>> +     gd->ram_buf = mem;
>
> shouldn't this 128 MiB be a config ?

Will add one.

>
>> +#ifdef CONFIG_POST
>> +     post_bootmode_init();
>> +     post_run(NULL, POST_ROM | post_bootmode_get(0));
>> +#endif
>
> i wonder if you shouldn't just drop all the POST stuff for now ...
> -mike
>

OK will do.

Regards,
Simon


More information about the U-Boot mailing list