[U-Boot] [PATCH] powerpc/mpc8xxx: Fix ddr build error

[Becky Bruce]

On Oct 3, 2011, at 8:40 PM, Tabi Timur-B04825 wrote:

> On Mon, Oct 3, 2011 at 6:59 PM, Becky Bruce <beckyb at kernel.crashing.org> wrote:
> 
>> -#ifdef DEBUG
>>  const char *step_string_tbl[] = {
>>        "STEP_GET_SPD",
>>        "STEP_COMPUTE_DIMM_PARMS",
>> @@ -153,7 +152,6 @@ const char * step_to_string(unsigned int step) {
>> 
>>        return step_string_tbl[s];
>>  }
>> -#endif
> 
> How big is this array?  It looks like it's going to add a bunch of
> data to the u-boot image that will typically never be used, since
> DEBUG is usually not defined.
> 
> There should be an easy way to keep this array defined only when DEBUG
> is defined.

It's got like 7 or 8 members so it's not that big and the code that gets enabled is < 5 lines.   I thought about just yanking out the debug() that uses this stuff but assumed somebody actually needed it.

Feel free to publish a different patch if you want a different fix. 

-B