[U-Boot] [PATCH v2 1/2] mx25: generic.c: Fix coding style

[Stefano Babic]

On 10/05/2011 03:02 AM, Fabio Estevam wrote:
> Running checkpatch on arch/arm/cpu/arm926ejs/mx25/generic.c we get:
> 
> total: 2 errors, 59 warnings, 326 lines checked
> 
> Fix these errors and warnings.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
> Changes since v1:
> - Fixed typo on subject
> 
>  arch/arm/cpu/arm926ejs/mx25/generic.c |  110 ++++++++++++++++----------------
>  1 files changed, 55 insertions(+), 55 deletions(-)
> 

Hi Fabio,

what about to squash all your patches of this type into a single patch ?
It seems to me they all fix coding style in i.MX code according to the
result of checkpatch, and in most cases the changes are due to
whitespace before parenthesis. So the rule to fix a single issue in one
patch is IMHO maintained.

I have not checked, but a single patch should not overwrite the maximum
size allowed for this ML.

I am wondering if this method should be exported for all U-Boot code. I
agree to push your patches, but most issues reported by checkpatch are
due to different coding style between u-boot and linux in the past and
checkpatch reports surely a lot of warnings on old u-boot code.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================