[U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

Wolfgang Denk wd at denx.de
Thu Oct 6 19:39:38 CEST 2011


Dear Lei Wen,

In message <CALZhoSRhbf2vMU5oLP3Hwh4yQ4xFip19aJD24Gn4sy-RM6B+Eg at mail.gmail.com> you wrote:
>
> The ext_csd current usage in mmc.c is not too much, here I mean only few of
> the fields of the ext_csd is used, also fully definition of ext_csd
> member would seems so huge a structure at its appearence...
> 
> So macro may looks more concise and could parse from its meaning easily eno=
> ugh.

We do not accept (typeless) register offset definitions. Please use a
struct, so the compiler has a chance to perform type checking.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"An open mind has but one disadvantage: it collects dirt."
                                                    - a saying at RPI


More information about the U-Boot mailing list